fix: label timeout estimate as 'total window' not remaining time#21
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: label timeout estimate as 'total window' not remaining time#21Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
The timeout block estimate was computed as timeoutBlock - initiatedBlock, which is the total swap window duration, not remaining time. The label now says 'total window' to prevent users from misreading it as time remaining. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the timeout block estimate label from
windowtototal windowinSwapDetailPage.tsx. The estimate is calculated astimeoutBlock - initiatedBlock, which is the full swap duration — not remaining time. The misleading label could cause users to believe a swap has more time remaining than it actually does.@anderdc @LandynDev
Related Issues
Fixes #20
Type of Change
Screenshots
Before:
Block #12345 (~20 min window)After:
Block #12345 (~20 min total window)Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses